search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix: silently ignore missing configuration file #104

Closed padamstx closed 3 years ago

padamstx commented 3 years ago

While attempting to read configuration properties from the config file specified via ${IBM_CREDENTIALS_FILE}, the read_external_sources() function should silently ignore an error if the file doesn't exist, and then proceed to the next step of the config algorithm. This was not working correctly, but this commit fixes that.

Also fixes: #60

codecov[bot] commented 3 years ago

Codecov Report

Merging #104 (4847dff) into master (d6238b1) will increase coverage by 0.44%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #104      +/-   ##
==========================================
+ Coverage   98.21%   98.65%   +0.44%     
==========================================
  Files          18       18              
  Lines         672      669       -3     
==========================================
  Hits          660      660              
+ Misses         12        9       -3
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 96.96% <100.00%> (+1.64%) :arrow_up:
ibm_cloud_sdk_core/utils.py 99.21% <100.00%> (+0.01%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6238b1...4847dff. Read the comment docs.

ibm-devx-automation commented 3 years ago

:tada: This PR is included in version 3.5.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: