search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix: remove reserved keywords from kwargs before passing it to requests #117

Closed pyrooka closed 3 years ago

pyrooka commented 3 years ago

This PR introduces a minor change/improvement: removal of some reserved keys from the kwargs of the base services' send function.

codecov[bot] commented 3 years ago

Codecov Report

Merging #117 (24dddc9) into main (6614a63) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #117   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          18       18           
  Lines         732      737    +5     
=======================================
+ Hits          723      728    +5     
  Misses          9        9
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 97.39% <100.00%> (+0.06%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6614a63...24dddc9. Read the comment docs.

pyrooka commented 3 years ago

Sure!

ibm-devx-sdk commented 3 years ago

:tada: This PR is included in version 3.10.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: