search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

feat: implement container authentication #119

Closed pyrooka closed 3 years ago

pyrooka commented 3 years ago

This PR implements the new container authentication flow, which is highly based on the IAM auth. This means a new token manager and authenticator have been created and covered with tests.

NOTE: this PR/branch is based on the IAM refactoring branch(shared-iam-related-code)/PR(#118), so SHOULD NOT be merged in before the other one.

codecov[bot] commented 3 years ago

Codecov Report

Merging #119 (5fba59b) into main (e0aeed7) will increase coverage by 0.09%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   98.92%   99.01%   +0.09%     
==========================================
  Files          20       22       +2     
  Lines         746      816      +70     
==========================================
+ Hits          738      808      +70     
  Misses          8        8
Impacted Files Coverage Δ
.../authenticators/iam_request_based_authenticator.py 100.00% <ø> (ø)
ibm_cloud_sdk_core/__init__.py 100.00% <100.00%> (ø)
ibm_cloud_sdk_core/authenticators/__init__.py 100.00% <100.00%> (ø)
...sdk_core/authenticators/container_authenticator.py 100.00% <100.00%> (ø)
...loud_sdk_core/authenticators/cp4d_authenticator.py 100.00% <100.00%> (ø)
...cloud_sdk_core/authenticators/iam_authenticator.py 100.00% <100.00%> (ø)
ibm_cloud_sdk_core/get_authenticator.py 100.00% <100.00%> (ø)
...sdk_core/token_managers/container_token_manager.py 100.00% <100.00%> (ø)
ibm_cloud_sdk_core/token_managers/token_manager.py 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0aeed7...5fba59b. Read the comment docs.

padamstx commented 3 years ago

@pyrooka Looks like there's a linter error in the builds :)

pyrooka commented 3 years ago

Thank you for fixing these issues @padamstx !

ibm-devx-sdk commented 3 years ago

:tada: This PR is included in version 3.11.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: