search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix: encode serialized JSON string as UTF-8 #121

Closed pyrooka closed 3 years ago

pyrooka commented 3 years ago

This PR adds encoding to the serialized JSON payload. We are already doing this if the payload is passed as a string.

In the generated SDKs, for example in the Platform Services/Case Management, we serialize the data dictionary and pass it to the prepare_request function as a string, therefore I think it's safe to add encoding here.

codecov[bot] commented 3 years ago

Codecov Report

Merging #121 (f5dfa5c) into main (5395f65) will increase coverage by 0.48%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
+ Coverage   99.01%   99.50%   +0.48%     
==========================================
  Files          22       22              
  Lines         816      815       -1     
==========================================
+ Hits          808      811       +3     
+ Misses          8        4       -4
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 99.47% <100.00%> (+2.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5395f65...f5dfa5c. Read the comment docs.

ibm-devx-sdk commented 3 years ago

:tada: This PR is included in version 3.11.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: