search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix(retries): change default retry_interval to 1 second (was 0.1) #122

Closed padamstx closed 3 years ago

padamstx commented 3 years ago

This commit changes the default value of the retry_interval parameter (in the BaseService.enable_retries method) from 0.1 to 1.0. This will result in default retry intervals of 1, 2, 4, 8, ... seconds instead of 0.1, 0.2, 0.4, 0.8, ... seconds. This change will align the python core retry support with Go. Also added some detailed info in the docstring for the method as well.

codecov[bot] commented 3 years ago

Codecov Report

Merging #122 (96412af) into main (a15df4b) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #122   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          22       22           
  Lines         815      815           
=======================================
  Hits          811      811           
  Misses          4        4
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 99.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a15df4b...96412af. Read the comment docs.

ibm-devx-sdk commented 3 years ago

:tada: This PR is included in version 3.11.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: