search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix: multiple IAM based authenticator overrides #124

Closed pyrooka closed 3 years ago

pyrooka commented 3 years ago

This PR fixes an issue which happens when the user creates more than one IAM based authenticator in the same service/project/file. The cause of this issue is the request_payload class variable, because it should be an instance variable. Tests have been added, fixed and improved.

Closes #123

Update: there are also some unicode string and utf-8 encoding related changes in this PR to make the code compatible with the latest pylint release.

codecov[bot] commented 3 years ago

Codecov Report

Merging #124 (aacfde8) into main (4ac1246) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          22       22           
  Lines         815      815           
=======================================
  Hits          811      811           
  Misses          4        4
Impacted Files Coverage Δ
...sdk_core/token_managers/container_token_manager.py 100.00% <100.00%> (ø)
.../token_managers/iam_request_based_token_manager.py 100.00% <100.00%> (ø)
ibm_cloud_sdk_core/utils.py 99.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4ac1246...aacfde8. Read the comment docs.

ibm-devx-sdk commented 3 years ago

:tada: This PR is included in version 3.11.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: