search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

chore(build): use node 14 for new semantic-release #125

Closed padamstx closed 3 years ago

padamstx commented 3 years ago

This PR bumps us up to node v14 to accommodate the new semantic-release v18

For some reason, my initial change to bump node to v14 resulted in some additional lint warnings related to the use f-strings and failed the build. I added another change to disable that lint check as a bit of research revealed that it's a dubious check to perform anyhow :)

codecov[bot] commented 3 years ago

Codecov Report

Merging #125 (514937f) into main (fde6160) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          22       22           
  Lines         815      815           
=======================================
  Hits          811      811           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fde6160...514937f. Read the comment docs.

ibm-devx-sdk commented 3 years ago

:tada: This PR is included in version 3.12.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: