IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

feat: add authentication_type method to authenticators #127

Closed padamstx closed 3 years ago

padamstx commented 3 years ago

This commit adds a new method ('authentication_type()') to the Authenticator base class, and each authenticator implementation (subclasses of Authenticator). The function will return a string indicating the authenticator type ('basic', 'iam', etc.). This brings the python core in line with the Go, Java and Node cores.

codecov[bot] commented 3 years ago

Codecov Report

Merging #127 (c45f65a) into main (52ab020) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   99.50%   99.52%   +0.01%     
==========================================
  Files          22       22              
  Lines         815      835      +20     
==========================================
+ Hits          811      831      +20     
  Misses          4        4              
Impacted Files Coverage Δ
ibm_cloud_sdk_core/authenticators/authenticator.py 88.23% <100.00%> (+13.23%) :arrow_up:
...oud_sdk_core/authenticators/basic_authenticator.py 100.00% <100.00%> (ø)
..._core/authenticators/bearer_token_authenticator.py 100.00% <100.00%> (ø)
...sdk_core/authenticators/container_authenticator.py 100.00% <100.00%> (ø)
...loud_sdk_core/authenticators/cp4d_authenticator.py 100.00% <100.00%> (ø)
...cloud_sdk_core/authenticators/iam_authenticator.py 100.00% <100.00%> (ø)
...d_sdk_core/authenticators/no_auth_authenticator.py 100.00% <100.00%> (ø)
ibm_cloud_sdk_core/get_authenticator.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 52ab020...c45f65a. Read the comment docs.

ibm-devx-sdk commented 3 years ago

:tada: This PR is included in version 3.12.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: