feat(CP4D Authentication): add ssl verification for self-signed certificates

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.

Apache License 2.0

20 stars 27 forks source link

feat(CP4D Authentication): add ssl verification for self-signed certificates #147

Closed LBExposito closed 2 years ago

LBExposito commented 2 years ago

These modifications allow the user to have a self-signed certificate in the SSL verification process when authenticating to an STT instance on CP4D.

The verify attribute is used by the requests python module to indicate the path to a custom CA Bundle (resquests documentation).

With these changes, it wont be necessary to disable ssl verification anymore when using a self-signed certificate with STT on CP4D.

CLAassistant commented 2 years ago

All committers have signed the CLA.

bobfang commented 2 years ago

to elaborate a bit more on this, these changes are for the Authentication step (getting a token). During regular SDK calls we can still pass verify as a kwarg and get it passed through to Requests.

LBExposito commented 2 years ago

Docstrings are updated !

ibm-devx-sdk commented 2 years ago

:tada: This PR is included in version 3.16.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: