search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

vault-token vs. sa-token #164

Closed data-henrik closed 4 months ago

data-henrik commented 1 year ago

For Compute Resource authentication through Kubernetes (Container Authentication), the IKS docs use sa-token in their examples: https://cloud.ibm.com/docs/containers?topic=containers-pod-iam-identity&interface=ui

Why is this core SDK using vault-token as default? Some sync required to improve user experience. Initially, I ran into an error assuming that the default value in the SDK would match the default...

padamstx commented 1 year ago

I wasn't aware of any official default filename that's suported by the IKS/IAM infrastructure, and the examples we saw when implementing the authenticators used "vault-token" so we simply picked that as the default. Why the doc writers used "sa-vault" in the IKS docs is a mystery :)

padamstx commented 1 year ago

I've confirmed that there is no official default used by the IKS intrastructure, and the only user hints would be the examples in the IKS docs. I'll resolve this issue by introducing a second default ("sa-token") that is tried if the first default ("vault-token") doesn't exist (we can't remove support for "vault-token" as that would potentially break existing users that are relying on that behavior).

padamstx commented 4 months ago

I noticed that this issue is still open. I checked on the various core libraries (Go, Java, Node.js and Python) and this request has been implemented in each one. Closing the issue...