search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix: use the correct SSL config if cert verification is disabled #187

Closed pyrooka closed 8 months ago

pyrooka commented 8 months ago

It turned out, disabling the SSL certificate verification didn't work as expected. We passed the right arguments to the requests package, but since we use a custom SSL context, it couldn't turn off the verification entirely, because the default SSL context has the check_hostname set to True and the documentation says the following: "verify_mode is now automatically changed to CERT_REQUIRED when hostname checking is enabled and verify_mode is CERT_NONE." This commit adds an addition step which disables the hostname checking in our custom SSL context.

Ref: https://github.com/IBM/python-sdk-core/issues/186

ibm-devx-sdk commented 8 months ago

:tada: This PR is included in version 3.19.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: