search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix: improve the detection and loading of default certificates #197

Closed pyrooka closed 2 months ago

pyrooka commented 2 months ago

Follow up PR of https://github.com/IBM/python-sdk-core/pull/196. Turned out in some cases - especially in containers - the certificate verification is still failing due to the missing certs. It's because the location of those files really depend on the system and the OpenSSL configuration. This PR adds a workaround for this problem, by loading the default certs from the location that the certifi package reports. The requests package uses the same logic, so it should cause no issues.

pyrooka commented 2 months ago

That's a really good point! About the requirements, I did not add the certifi package on purpose, but now it doesn't matter anymore as we've stopped referencing to that.

ibm-devx-sdk commented 2 months ago

:tada: This PR is included in version 3.20.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: