IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

vcap and json loads changes #22

Closed ehdsouza closed 5 years ago

ehdsouza commented 5 years ago

This PR supports the following:

codecov[bot] commented 5 years ago

Codecov Report

Merging #22 into next will increase coverage by 0.22%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #22      +/-   ##
==========================================
+ Coverage   97.76%   97.99%   +0.22%     
==========================================
  Files          16       16              
  Lines         492      498       +6     
==========================================
+ Hits          481      488       +7     
+ Misses         11       10       -1
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 96.74% <100%> (+0.08%) :arrow_up:
ibm_cloud_sdk_core/utils.py 98.01% <100%> (+1.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7eb7e88...8ef48a1. Read the comment docs.

padamstx commented 5 years ago
* Temporary handle vcap services... This is a temporary change as we pass in only `service name`. So a VCAP service like `compare-and-comply` would be converted to `compare_and_comply`

We shouldn't be doing any transformation on the service name when we use it to retrieve an entry in VCAP_SERVICES. If the service name obtained from the API definition and inserted into the generated code is "compare-and-comply", then that's the key that we'd expect to find in VCAP_SERVICES. We only do the transformation on the service name when looking for properties in the credential file or environment variables.
There is a section on this in the Authentication design: https://github.ibm.com/CloudEngineering/openapi-sdkgen/wiki/Core-SDK-Authentication-Design#a-note-about-service-names

ehdsouza commented 5 years ago

@padamstx this was done temporary before the meeting as a candidate release had to get out

watson-github-bot commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: