IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

Change order of credential path and read_external_sources and more #28

Closed ehdsouza closed 5 years ago

ehdsouza commented 5 years ago

This PR does the following:

related to https://github.ibm.com/Watson/developer-experience/issues/7521

codecov[bot] commented 5 years ago

Codecov Report

Merging #28 into next will decrease coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next      #28      +/-   ##
==========================================
- Coverage   98.18%   98.15%   -0.04%     
==========================================
  Files          16       16              
  Lines         497      488       -9     
==========================================
- Hits          488      479       -9     
  Misses          9        9
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 97.39% <100%> (-0.15%) :arrow_down:
ibm_cloud_sdk_core/utils.py 97.97% <100%> (-0.05%) :arrow_down:
ibm_cloud_sdk_core/__init__.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7ecc329...164d02e. Read the comment docs.

ehdsouza commented 5 years ago

@padamstx addressed the multi word service name issue.

watson-github-bot commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: