search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix: support duplicate part names in 'files' parameter of prepare_req… #30

Closed padamstx closed 5 years ago

padamstx commented 5 years ago

Fixes: https://github.ibm.com/arf/planning-sdk-squad/issues/1064

This PR allows the "prepare_request" caller to pass in a list of tuples (e.g. [(part-name, (file-tuple)), ...]) for the 'files' parameter instead of a dictionary. Each list item will result in a separate part to be created in the multi-part form. This change allows multiple list items to use the same part-name.

CLAassistant commented 5 years ago

CLA assistant check
All committers have signed the CLA.

codecov[bot] commented 5 years ago

Codecov Report

Merging #30 into next will increase coverage by 0.02%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##            next      #30      +/-   ##
=========================================
+ Coverage   97.2%   97.22%   +0.02%     
=========================================
  Files         16       16              
  Lines        500      504       +4     
=========================================
+ Hits         486      490       +4     
  Misses        14       14
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 93.89% <100%> (+0.19%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4fcaa66...ae6702f. Read the comment docs.

watson-github-bot commented 5 years ago

:tada: This PR is included in version 1.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: