search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

feat: expand vcap credential loading to support user-defined service names #48

Closed padamstx closed 4 years ago

padamstx commented 4 years ago

This PR serves two purposes: 1) Adds a commit with a properly-formatted commit message pertaining to the recent work to modify our VCAP_SERVICES function to support user-defined service names. 2) Adds python 3.8 to our list of versions that are used during Travis builds. This list now includes 3.5, 3.6, 3.7 and 3.8.

codecov[bot] commented 4 years ago

Codecov Report

Merging #48 into master will increase coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   97.55%   97.58%   +0.02%     
==========================================
  Files          17       17              
  Lines         573      579       +6     
==========================================
+ Hits          559      565       +6     
  Misses         14       14
Impacted Files Coverage Δ
ibm_cloud_sdk_core/jwt_token_manager.py 100% <0%> (ø) :arrow_up:
ibm_cloud_sdk_core/base_service.py 93.95% <0%> (+0.16%) :arrow_up:
ibm_cloud_sdk_core/authenticators/authenticator.py 75% <0%> (+3.57%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b3cf8ee...e67ce1a. Read the comment docs.

ibm-devx-automation commented 4 years ago

:tada: This PR is included in version 1.2.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: