search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

Make optional parameters keyword-only #61

Closed rmkeezer closed 4 years ago

rmkeezer commented 4 years ago

Add a separator between positional and optional parameters and make optional parameters "keyword-only". This requires the user to specify the optional parameter they are setting instead of the relying on the position, since the arguments of an interface may change in the future.

https://python-3-for-scientists.readthedocs.io/en/latest/python3_advanced.html#keyword-only-arguments

codecov[bot] commented 4 years ago

Codecov Report

Merging #61 into master will not change coverage by %. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #61   +/-   ##
=======================================
  Coverage   97.88%   97.88%           
=======================================
  Files          17       17           
  Lines         616      616           
=======================================
  Hits          603      603           
  Misses         13       13
Impacted Files Coverage Δ
...loud_sdk_core/authenticators/cp4d_authenticator.py 100.00% <ø> (ø)
...cloud_sdk_core/authenticators/iam_authenticator.py 96.66% <ø> (ø)
ibm_cloud_sdk_core/detailed_response.py 100.00% <ø> (ø)
ibm_cloud_sdk_core/iam_token_manager.py 100.00% <ø> (ø)
ibm_cloud_sdk_core/api_exception.py 100.00% <100.00%> (ø)
ibm_cloud_sdk_core/base_service.py 93.83% <100.00%> (ø)
ibm_cloud_sdk_core/cp4d_token_manager.py 100.00% <100.00%> (ø)
ibm_cloud_sdk_core/jwt_token_manager.py 100.00% <100.00%> (ø)
ibm_cloud_sdk_core/utils.py 99.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e6090d...0dbccb1. Read the comment docs.