search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

[Breaking] Only override content-type if it is none #62

Closed rmkeezer closed 4 years ago

rmkeezer commented 4 years ago

ref: https://github.ibm.com/arf/planning-sdk-squad/issues/1201

Currently the header content-type is unconditionally overridden to "application/json". This change will only add it if the header is not set.

codecov[bot] commented 4 years ago

Codecov Report

Merging #62 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #62   +/-   ##
=======================================
  Coverage   97.88%   97.89%           
=======================================
  Files          17       17           
  Lines         616      617    +1     
=======================================
+ Hits          603      604    +1     
  Misses         13       13
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 93.87% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9e6090d...a4ed484. Read the comment docs.