search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

Merge Python3 breaking changes from V2 to master #68

Closed rmkeezer closed 4 years ago

rmkeezer commented 4 years ago

And ensure that the commit message is semantic release friendly for a breaking change πŸ‘

codecov[bot] commented 4 years ago

Codecov Report

Merging #68 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #68      +/-   ##
==========================================
+ Coverage   97.88%   97.89%   +0.01%     
==========================================
  Files          17       17              
  Lines         616      619       +3     
==========================================
+ Hits          603      606       +3     
  Misses         13       13
Impacted Files Coverage Ξ”
ibm_cloud_sdk_core/api_exception.py 100.00% <100.00%> (ΓΈ)
ibm_cloud_sdk_core/authenticators/authenticator.py 75.00% <100.00%> (ΓΈ)
...oud_sdk_core/authenticators/basic_authenticator.py 100.00% <100.00%> (ΓΈ)
..._core/authenticators/bearer_token_authenticator.py 100.00% <100.00%> (ΓΈ)
...loud_sdk_core/authenticators/cp4d_authenticator.py 100.00% <100.00%> (ΓΈ)
...cloud_sdk_core/authenticators/iam_authenticator.py 96.66% <100.00%> (ΓΈ)
...d_sdk_core/authenticators/no_auth_authenticator.py 100.00% <100.00%> (ΓΈ)
ibm_cloud_sdk_core/base_service.py 93.87% <100.00%> (+0.04%) :arrow_up:
ibm_cloud_sdk_core/cp4d_token_manager.py 100.00% <100.00%> (ΓΈ)
ibm_cloud_sdk_core/detailed_response.py 100.00% <100.00%> (ΓΈ)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 3852c18...23430c6. Read the comment docs.

padamstx commented 4 years ago

Before we can merge the v2 branch into master, we'll need to do these things:

  1. Do a rebase on the current master branch since this PR thinks the v2 branch is out of date.
  2. Make sure that each of the commit messages in the v2 branch are correct. i.e. whichever commits represent breaking changes should have the appropriate "BREAKING CHANGE" mesage.

For #2, this might be all of the commits, in which case we could do this:

  1. create a new "v2" branch, maybe call it "v2-new".
  2. one at a time, and in the same order as the commits appear in the "v2" branch, cherry-pick a commit from "v2" into "v2-new", then run git commit --amend to modify the commit message so that it properly reflects a breaking change.
  3. when each commit from "v2" has been handled in step 2, you could remove your local "v2" branch, then rename "v2-new" to be "v2", then run git push -f to update in place the "v2" branch (i.e. your PR).
  4. after the build is clean, etc. the updated "v2" branch can be merged into master.
ibm-devx-automation commented 4 years ago

:tada: This PR is included in version 2.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: