search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix: Don't rstrip slash when service_url is none #74

Closed rmkeezer closed 4 years ago

rmkeezer commented 4 years ago

When service_url is none, rstrip will fail, this keeps the functionality before rstrip was added.

codecov[bot] commented 4 years ago

Codecov Report

Merging #74 into master will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   97.89%   97.90%           
=======================================
  Files          17       17           
  Lines         619      621    +2     
=======================================
+ Hits          606      608    +2     
  Misses         13       13
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 93.95% <100.00%> (+0.08%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea6cf85...cfa9581. Read the comment docs.

ibm-devx-automation commented 4 years ago

:tada: This PR is included in version 2.0.3 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: