search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix: Revert service_url slash stripping to work with current tests #75

Closed rmkeezer closed 4 years ago

rmkeezer commented 4 years ago

Stripping the service url is incompatible with the current python unit tests. We will need to make a generator change along with the stripping change if we want to make them compatible.

codecov[bot] commented 4 years ago

Codecov Report

Merging #75 into master will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
- Coverage   97.90%   97.89%   -0.01%     
==========================================
  Files          17       17              
  Lines         621      619       -2     
==========================================
- Hits          608      606       -2     
  Misses         13       13
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 93.87% <100.00%> (-0.09%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8688f2f...e5e02fe. Read the comment docs.

ibm-devx-automation commented 4 years ago

:tada: This PR is included in version 2.0.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: