rmkeezer commented 4 years ago

ref: https://github.ibm.com/arf/planning-sdk-squad/issues/1669

The fix added for stripping trailing slashes in both request URLs and service URLs causes an inconsistency in the python unit tests when checking the request and response URL.

Since changing the unit tests to to work with this core change would break compatibility for previous versions, this change is being moved to the v3.x version of the core where the new generator version with the unit test fix can specify the new core version.

codecov[bot] commented 4 years ago

Codecov Report

Merging #76 into master will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   97.89%   97.89%           
=======================================
  Files          17       17           
  Lines         619      619           
=======================================
  Hits          606      606           
  Misses         13       13

Impacted Files	Coverage Δ
ibm_cloud_sdk_core/base_service.py	`93.87% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5da47e2...8b56713. Read the comment docs.

ibm-devx-automation commented 4 years ago

:tada: This PR is included in version 2.0.5 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

IBM / python-sdk-core

fix: Revert stripping request URL trailing slashes #76

Codecov Report