search

IBM / python-sdk-core

The python-sdk-core repository contains core functionality required by Python code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
20 stars 27 forks source link

fix: Combine multiple ending slashes to one #77

Closed rmkeezer closed 4 years ago

rmkeezer commented 4 years ago

ref: https://github.ibm.com/arf/planning-sdk-squad/issues/1786

This fix combines the trailing slashes together to one. Since trailing slash and no trailing slash can mean different endpoints based on the server, we must repect which path is chosen.

Fixing the request URL like this will break compatibility with previous generator versions since their unit tests use the un-filtered url in the responses object.

codecov[bot] commented 4 years ago

Codecov Report

Merging #77 into master will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #77      +/-   ##
==========================================
+ Coverage   97.95%   97.96%   +0.01%     
==========================================
  Files          18       18              
  Lines         636      640       +4     
==========================================
+ Hits          623      627       +4     
  Misses         13       13
Impacted Files Coverage Δ
ibm_cloud_sdk_core/base_service.py 93.87% <100.00%> (ø)
ibm_cloud_sdk_core/utils.py 99.19% <100.00%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c02d4b...a6136ad. Read the comment docs.

ibm-devx-automation commented 4 years ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: