search

IBM / report-toolkit

A toolkit for consumers of Node.js diagnostic Reports
https://ibm.github.io/report-toolkit
Other
84 stars 10 forks source link

explicitly support third-party Rules #32

Closed boneskull closed 5 years ago

boneskull commented 5 years ago

We have some functions in @report-toolkit/fs that are presently not used. This is due, in part, to bundling a CJS module.

At present, only built-in Rules are accessible via the inspect CLI command. This is a bug. We need to be able to load third-party rules via require(), at minimum.

Ensure the present functionality supports this (see fs-rule-loader.js), and write tests.

boneskull commented 5 years ago

It probably makes sense to consolidate the rules and inspector packages, as rules cannot be used standalone. this was more of a logical grouping instead of a functional one.

boneskull commented 5 years ago

strategy maybe should be:

  1. pull in builtin rules like we're doing
  2. support a plugins prop in the config
  3. load stuff from those

also list-rules may want to look at the config and then list those in plugins. might want to do this for first step "PoC" style