IBM / report-toolkit

A toolkit for consumers of Node.js diagnostic Reports
https://ibm.github.io/report-toolkit
Other
84 stars 10 forks source link

config overhaul; closes #47 #86

Closed boneskull closed 4 years ago

boneskull commented 4 years ago

This removes @report-toolkit/config and moves its contents into @report-toolkit/common. Modified the config format somewhat & defined some types for it.

Not sure of the best way to distribute the format. A .d.ts will be available, but it's kind of buried...

codecov[bot] commented 4 years ago

Codecov Report

Merging #86 into master will increase coverage by 1.82%. The diff coverage is 92.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage    82.8%   84.63%   +1.82%     
==========================================
  Files          51       51              
  Lines         913      911       -2     
==========================================
+ Hits          756      771      +15     
+ Misses        157      140      -17
Impacted Files Coverage Δ
packages/cli/src/commands/diff.js 72.22% <ø> (-27.78%) :arrow_down:
packages/cli/src/commands/inspect.js 89.47% <ø> (ø) :arrow_up:
packages/cli/src/commands/redact.js 47.05% <ø> (ø) :arrow_up:
packages/cli/src/commands/transform.js 100% <ø> (ø) :arrow_up:
packages/cli/src/commands/list-rules.js 100% <ø> (ø) :arrow_up:
packages/cli/src/console-utils.js 58.33% <ø> (ø) :arrow_up:
packages/common/src/configs/recommended.js 100% <100%> (ø)
packages/core/src/observable.js 90.16% <100%> (+0.16%) :arrow_up:
packages/inspector/src/rule.js 95.16% <100%> (ø) :arrow_up:
packages/cli/src/commands/common.js 58.33% <66.66%> (ø) :arrow_up:
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2984c7f...ec0f335. Read the comment docs.

boneskull commented 4 years ago

Coverage decrease--I think--is due to removal of @report-toolkit/config