search

IBM / rl-testbed-for-energyplus

Reinforcement Learning Testbed for Power Consumption Optimization using EnergyPlus
MIT License
191 stars 77 forks source link

Add requirements.txt #54

Closed antoine-galataud closed 3 years ago

antoine-galataud commented 3 years ago

Fixes #53 Fixes #50 Fixes #52

This pull request introduces a requirements.txt file to simplify setup of python dependencies and upgrades baselines from 0.1.5 to 0.1.6, which has impact on some signatures that I updated.

Signed-off-by: Antoine Galataud antoine@foobot.io

antoine-galataud commented 3 years ago

@takaomoriyama please review.

takaomoriyama commented 3 years ago

@antoine-galataud I checked the PR on Ubuntu 18.04.2 LTS with python 3.6.9, and got following error when installing dependency modules:

$ pip3 install -r requirements.txt
...
ERROR: Cannot install -r requirements.txt (line 7) and gym==0.18.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested gym==0.18.0 <-- Note: Why Anotoine selected gym 0.18 ?
    baselines 0.1.6 depends on gym<0.16.0 and >=0.15.4

The current version of baseline at https://github.com/openai/baselines.git (I think it's v. 0.1.6) has dependency on gym [0.15.4, 0.16.0).

What do you recommend to resolve this conflict ? If we set back to gym v. 0.15.7, it went well.

antoine-galataud commented 3 years ago

@takaomoriyama I didn't stumble upon this issue on my side, but since baselines 0.1.6 depends on fixed range of versions, it's the way to go. I'll update the file with 0.15.7 as suggested.