search

IBM / rl-testbed-for-energyplus

Reinforcement Learning Testbed for Power Consumption Optimization using EnergyPlus
MIT License
186 stars 77 forks source link

Add patch and model files for EnergyPlus V22.1.0 #91

Closed jmarrec closed 2 years ago

jmarrec commented 2 years ago

Have you considered - or already tried ? - upstreaming these changes to the E+ codebase?

Anyways, I also launched a new release on my fork of E+ at https://github.com/jmarrec/EnergyPlus/releases/tag/v22.1.0-rl-testbed, so V22.1.0 patched binaries will be available there directly in about one hour, so people don't need to build E+ manually.

antoine-galataud commented 2 years ago

@jmarrec thanks for the patch! And thanks for the E+ release, this will save a lot of time.

Note that there's also a docker image that serves the same purpose (speeding up the build). Would be awesome if you could also update docker/Dockerfile to point to this new E+ version (first 2 lines). I've tested to build and run already, works fine. I'll also publish these docker images as public github packages soon, I will advertise about later .

The patch was never proposed for an integration in E+ codebase (as far as I know). I'm wondering how it would be welcomed: it could be seen as duplicate feature (there's already BCVTB, and since recently the python API). On the other hand this patch is perfect for both small scale studies (ie one model to tweak) since it avoids juggling with extra dependencies, and larger scale too, since it's easy to generate the EMS code (best with OpenStudio SDK). What's your take on that?