Closed jorge-ibm closed 4 years ago
Hi - @padamstx, @mkistler, @mamoonraja these changes are ready for review.
Hi @padamstx - this is ready for re-review.
@mamoonraja could you please give this PR a look. Our main goals in this PR are: 1) Enhance the VCAP config loading algorithm to comply with our service config feature design, specially this section. 2) Fix some minor quirks related to loading service-level properties from external config sources.
There will be some minor changes to the Ruby generator that will go along with this Ruby core update. The plan would be to merge both PRs into the respective master branches at about the same time (@jorge-ibm is working on the Ruby generator updates now).
:tada: This PR is included in version 1.1.0 :tada:
The release is available on GitHub release
Your semantic-release bot :package::rocket:
Fixes: https://github.ibm.com/arf/planning-sdk-squad/issues/1142
Changes:
@conn
in the constructor, to prior to configuring the http client. Before, if disable ssl was set to true through the constructor arguments, this would cause a failure in theconfigure_http_client
method.