IBM / ruby-sdk-core

The ruby-sdk-core repository contains core functionality required by Ruby code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
3 stars 10 forks source link

feat(BaseService): add new method configure_service to BaseService class & enhance vcap parsing #26

Closed jorge-ibm closed 4 years ago

jorge-ibm commented 5 years ago

Fixes: https://github.ibm.com/arf/planning-sdk-squad/issues/1142

Changes:

jorge-ibm commented 4 years ago

Hi - @padamstx, @mkistler, @mamoonraja these changes are ready for review.

jorge-ibm commented 4 years ago

Hi @padamstx - this is ready for re-review.

padamstx commented 4 years ago

@mamoonraja could you please give this PR a look. Our main goals in this PR are: 1) Enhance the VCAP config loading algorithm to comply with our service config feature design, specially this section. 2) Fix some minor quirks related to loading service-level properties from external config sources.

There will be some minor changes to the Ruby generator that will go along with this Ruby core update. The plan would be to merge both PRs into the respective master branches at about the same time (@jorge-ibm is working on the Ruby generator updates now).

watson-github-bot commented 4 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: