Upgrade ruby, bundler, rubocop support

IBM / ruby-sdk-core

The ruby-sdk-core repository contains core functionality required by Ruby code generated by the IBM OpenAPI SDK Generator.

Apache License 2.0

3 stars 10 forks source link

Upgrade ruby, bundler, rubocop support #42

Closed jrafanie closed 1 year ago

jrafanie commented 1 year ago

Resolves the rubocop warnings mentioned in https://github.com/IBM/ruby-sdk-core/pull/41

Test with ruby 2.7, 3.0, 3.1. 2.7 is end of life and all prior are also but we can possibly keep 2.7 supportable for now. See: https://www.ruby-lang.org/en/downloads/branches/
Upgrade to bundler 2 and rubocop 1.40+
Fix some obvious rubocop violations
Remove all non-required .rubocop.yml settings to simplify the configuration

Note, this should probably bump the version since we're somewhat dropping support for older rubies.

pyrooka commented 1 year ago

@jrafanie Sorry for the late response! Can we merge this PR? I think so, but want to make sure it's ready and works fine, since this repo doesn't have automated builds.

jrafanie commented 1 year ago

@jrafanie Sorry for the late response! Can we merge this PR? I think so, but want to make sure it's ready and works fine, since this repo doesn't have automated builds.

@pyrooka let me rebase and test locally and report back if it's still good

jrafanie commented 1 year ago

@jrafanie Sorry for the late response! Can we merge this PR? I think so, but want to make sure it's ready and works fine, since this repo doesn't have automated builds.

@pyrooka let me rebase and test locally and report back if it's still good

ok, @pyrooka, I rebased and tested all of my rubies via:

bundle install
bundle exec rake

They all pass the cop checks and tests.

   ruby-2.7.8
   ruby-3.0.6
   ruby-3.1.4
   ruby-3.2.2

Let me know what we can do to get tests running on here via travis or github actions.

pyrooka commented 1 year ago

Thanks for checking it! I merge this now and will take a look how we could resurrect the Travis builds in this repo.