search

IBM / ruby-sdk-core

The ruby-sdk-core repository contains core functionality required by Ruby code generated by the IBM OpenAPI SDK Generator.
Apache License 2.0
3 stars 10 forks source link

Allow iam client id/secret to be configured #7

Closed padamstx closed 5 years ago

padamstx commented 5 years ago

Fixes: https://github.ibm.com/arf/planning-sdk-squad/issues/851

This PR allows the iam client id and secret values to be configured when instantiating the BaseService class. These values will then be used for basic auth when invoking the iam token service to request or refresh an IAM access token.

codecov[bot] commented 5 years ago

Codecov Report

Merging #7 into master will decrease coverage by 1.45%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
- Coverage     100%   98.54%   -1.46%     
==========================================
  Files           5        5              
  Lines         264      275      +11     
==========================================
+ Hits          264      271       +7     
- Misses          0        4       +4
Impacted Files Coverage Δ
lib/ibm_cloud_sdk_core/iam_token_manager.rb 100% <100%> (ø) :arrow_up:
lib/ibm_cloud_sdk_core/base_service.rb 97.54% <100%> (-2.46%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7d01df...bb13e4c. Read the comment docs.