Does sarama still guarantee message ordering?

IBM / sarama

Sarama is a Go library for Apache Kafka.

MIT License

11.43k stars 1.75k forks source link

Does sarama still guarantee message ordering? #2860

Open wenyihu6 opened 5 months ago

wenyihu6 commented 5 months ago

Description

Based on kafka documentation, "allowing retries while setting enable.idempotence to false and max.in.flight.requests.per.connection to greater than 1 will potentially change the ordering of records".

Sarama has a default configuration with a max of 3 retries, false idempotence, and a max of 5 in flight requests per connection.

Does this make the ordering guarantee in sarama no longer true?

awoods187 commented 3 months ago

This is related to this bug https://github.com/IBM/sarama/issues/2619. We are observing this having a challenging impact on our downstream customers of Cockroach Labs

richardartoul commented 2 months ago

Should be fixed by #2943 if someone can review