consumer group can not stop refresh meta data after context canceled.

erlangtui commented 1 month ago

Description

consumer group can not stop refresh meta data after context canceled.
function func (c *consumerGroup) Consume(ctx context.Context, topics []string, handler ConsumerGroupHandler) error in consumer_group.go file, after ctx's cancel function exec, the function c.client.RefreshMetadata(topics...) in consumer_group.go file line 201, still working, can not stop.

Versions

Sarama	Kafka	Go
1.38.1	kafka_2.11-1.1.1	1.19

Configuration

Logs

logs: CLICK ME

``` ```

Additional Context

erlangtui commented 1 month ago

the above happened when a broker is down

puellanivis commented 1 month ago

Hm… yeah. We even have the context available to plumb through that function. It seems that it’s relying on client.conf.Metadata.Timeout to provide a timeout/deadline rather than a context.WithDeadline or context.WithTimeout. It seems like plumbing a context through would even then simplify the deadline handling, since we wouldn’t have to do it all manually.

IBM / sarama