Why are SASL Handshake errors not logged ?

IBM / sarama

Sarama is a Go library for Apache Kafka.

MIT License

11.44k stars 1.75k forks source link

Why are SASL Handshake errors not logged ? #2994

Open pierDipi opened 2 hours ago

pierDipi commented 2 hours ago

Is there a security concern that prevents Sarama from logging SASL handshake errors?

I'm trying to debug an issue and the logger is only logging Error while performing SASL handshake kafka-1:9093 since the actual error is not logged, it's not clear what went wrong:

https://github.com/IBM/sarama/blob/893978c87fe7af13a2b6849ba62b003493f97f25/broker.go#L1243-L1252 https://github.com/IBM/sarama/blob/893978c87fe7af13a2b6849ba62b003493f97f25/broker.go#L260-L275

puellanivis commented 2 hours ago

Huh… I’m not at all sure why these would want to be logged at Info at all. They definitely seem like something that should be logged at error. Huh… they came in during PR https://github.com/IBM/sarama/pull/2234 with no comments.