IBM / scc-go-sdk

GoLang SDK for IBM Cloud Security and Compliance Center
https://cloud.ibm.com/docs/security-compliance
Apache License 2.0
2 stars 9 forks source link

Added Templates support to the Config Governance SDK #32

Closed NickXitco closed 3 years ago

NickXitco commented 3 years ago

PR summary

Added Templates support to the Config Governance SDK.

PR Checklist

Please make sure that your PR fulfills the following requirements:

Current vs new behavior

Only current behavior being modified is patching a small bug in the Config Governance Integration tests, where running it on an account with unlabeled rules would cause a crash in the AfterSuite() function.

Does this PR introduce a breaking change?

Other information

gary1998 commented 3 years ago

You need to rebase your branch with latest main branch. The ITs of notificationsv1 have been fixed.

NickXitco commented 3 years ago

You need to rebase your branch with latest main branch. The ITs of notificationsv1 have been fixed.

Can you elaborate on this? The branch is based on the latest main branch as far as I can see and rebasing had no effect.

NickXitco commented 3 years ago

Otherwise I believe the correct changes have been made

ashishth09 commented 3 years ago

Included in https://github.com/IBM/scc-go-sdk/pull/38 @NickXitco gave you access to create branch directly on this repo. The integration tests required credentials available only for the pull requests from this repo.