Closed NickXitco closed 3 years ago
You need to rebase your branch with latest main
branch. The ITs of notificationsv1
have been fixed.
You need to rebase your branch with latest
main
branch. The ITs ofnotificationsv1
have been fixed.
Can you elaborate on this? The branch is based on the latest main
branch as far as I can see and rebasing had no effect.
Otherwise I believe the correct changes have been made
Included in https://github.com/IBM/scc-go-sdk/pull/38 @NickXitco gave you access to create branch directly on this repo. The integration tests required credentials available only for the pull requests from this repo.
PR summary
Added Templates support to the Config Governance SDK.
PR Checklist
Please make sure that your PR fulfills the following requirements:
Current vs new behavior
Only current behavior being modified is patching a small bug in the Config Governance Integration tests, where running it on an account with unlabeled rules would cause a crash in the
AfterSuite()
function.Does this PR introduce a breaking change?
Other information