search

IBM / secret-map-dashboard

**work in progress**
4 stars 12 forks source link

Implementing degrading grid cell's color #121

Closed darrylbalderas closed 6 years ago

darrylbalderas commented 6 years ago

Fix typescript syntax errors Added tests for degrading grid cell's color

Related-issues: #105 Signed-off by: Darryl Balderas Darryl.Balderas@ibm.com

darrylbalderas commented 6 years ago

When I run it locally and all the tests pass. I don't understand why it is failing in the travis check? @AnthonyAmanse

screen shot 2018-02-22 at 7 46 50 am
AnthonyAmanse commented 6 years ago

LGTM, please rebase

darrylbalderas commented 6 years ago

@saar4ever I will make those changes 😄

darrylbalderas commented 6 years ago

@saar4ever How does that look? Also notice how fearless I made those changes to our project. The power of having test-cases 💯

darrylbalderas commented 6 years ago

@AnthonyAmanse Can you review this for me?