partially fix travis - Githubissues

IBM / serverless-language-translation

Create a communications channel using serverless technology to allow clients who speak different languages to seamlessly communicate with each other, built on Watson services.

https://developer.ibm.com/code/patterns/deploy-serverless-multilingual-conference-room/

Apache License 2.0

16 stars 35 forks source link

partially fix travis #13

Closed stevemar closed 6 years ago

stevemar commented 6 years ago

This is my attempt to try and get travis fixed. I cannot complete it fully because I have no idea where the params variable come from in handleIncomingSMS.py. This patch includes:

chmod 775 the shell files in tests
Modifying the two python files, handleIncomingSMS.py and iotPub.py to only have syntax errors related to params. This made the test-flake8.sh almost pass.
test-shellcheck.sh seems to be failing on stuff that is checked in as part of the initial CI patch, so not sure what to do about that.

TODO

(hopefully by someone not me)

Make test-shellcheck.sh pass
Make test-flake8.sh pass by fixing handleIncomingSMS.py.

Related to #12

stevemar commented 6 years ago

@kkbankol-ibm @loafyloaf thanks for the merge, but to be clear this doesn't completely fix things. I don't know how to address the params issue here: https://github.com/IBM/serverless-language-translation/blob/master/handleIncomingSMS.py#L35-L48

kkbankol-ibm commented 6 years ago

hey @stevemart, just updated those syntax issues for that handleIncomingSMS file

stevemar commented 6 years ago

@kkbankol-ibm please use pull requests rather than committing to master, we don't have a fresh CI result this way. Good to see that the bits we need are in the payload. We should probably update the variable name since dict is a predefined name in python.

@loafyloaf I suspect the build is still broken due to the shellchecker. But it fails on scripts we made to run the scripts. We should address that too.

stevemar commented 6 years ago