search

IBM / sliding-window-aggregators

Reference implementations of sliding window aggregation algorithms
Apache License 2.0
43 stars 16 forks source link

Pop in FifoWindow in Rust no longer returns value #48

Closed scotts closed 3 years ago

scotts commented 3 years ago

Closes #44

ktangwon commented 3 years ago

This looks great. Yes, I think evict in the TimeWindow should be updated as well, as @segeljakt has mentioned. In the case of a time window, the data structure should indicate whether or not the given timestamp leads to a successful eviction. But I'm not 100% sure what we should make it return, e.g., a flag or some real data. I realize this is a separate discussion (should it go into a new issue?).

scotts commented 3 years ago

Excellent, I'll make a separate issue to track evict in TimeWindow.