search

IBM / sourceorbit

Dependency Management for IBM i projects
https://ibm.github.io/sourceorbit/
Apache License 2.0
19 stars 10 forks source link

.objrefs fails to ignore unresolved object when it is referenced multiple times in source #67

Closed bmcpherson-srlife closed 2 months ago

bmcpherson-srlife commented 4 months ago

I have source which has two external files referenced to pull data from for validation. One is only referenced once (SYSCTL) in the source code while the other (USERCTL) is referenced three different times in the source code. I have listed both in the .objrefs file (see below) so the "No object found for reference" message will stop popping up.

# Files that exist outside this project

USERCTL.FILE
SYSCTL.FILE

However, I have noticed that only SYSCTL is no longer being mentioned in the "no reference" messages, but USERCTL is still showing up three times. But, the moment I comment out two of the three instances of USERCTL, the messages finally stop. I do not know if this is intended behavior, but I wanted to make mention of it.

Thanks!

worksofliam commented 4 months ago

@bmcpherson-srlife any chance you have a piece of source that has a reference to these files so I can try and create a test case?

Thanks!

bmcpherson-srlife commented 4 months ago

Hi Liam, please see the included file.

source_example.zip

It's probably worth another ticket, but the "so -bf bob" command produces a strange resulting Rules.mk file (also included, since it comes from the same source).

Thanks!

worksofliam commented 2 months ago

Interestingly enough. I think it was an easy issue? Looks like there was a space at the end of the line. I will fix this so spaces are ignored correctly.

image
worksofliam commented 2 months ago

Releasing in 0.10.3.

bmcpherson-srlife commented 2 months ago

Thank you for your hard work!