IBM / spacetech-kubesat

IBM Space Tech - Cognitive Autonomous Framework
Apache License 2.0
84 stars 16 forks source link

create a parent class for BaseSimulation #6

Closed minsikl closed 4 years ago

minsikl commented 4 years ago
Jordy24 commented 4 years ago

How do you suggest to go about on BaseService class, like what needs to be in there?.. And also the "simulation_timepulse" is just a topic/subject name so its not tied in anyway with BaseSimulation module.. Or could you please explain more on the BaseService class.

minsikl commented 4 years ago

simulation.timestamp callback is a simulation specific callback. So, it will be removed. node.status callback is useful to check the service status and can be used other than the simulation cases. Other functions will be kept in the BaseService.

minsikl commented 4 years ago

PR #18 has been merged