search

IBM / taxinomitis

Source code for Machine Learning for Kids site
https://machinelearningforkids.co.uk
Apache License 2.0
144 stars 137 forks source link

Translations to romanian #419

Closed oana-sipos closed 3 years ago

oana-sipos commented 3 years ago

@dalelane It was not fully clear if I need to translate pieces of information such as [TEXT] (label) or [TEXT] (confidence). Let me know if that is the case and I can add it in my next PR. Thank you!

dalelane commented 3 years ago

Thanks!

Anything in square brackets is a parameter name, so needs to be left untranslated.

For example, [TEXT] in https://github.com/IBM/taxinomitis/blob/9c1fbc7ff5cd6e723456d679908e161f0c5d992e/public/languages/ro.json#L1685

refers to the TEXT variable in https://github.com/IBM/taxinomitis/blob/9c1fbc7ff5cd6e723456d679908e161f0c5d992e/resources/scratch3-text-classify.js#L139

Anything in round brackets is just displayed on the block, so is fine to translate.

For example, (label) in https://github.com/IBM/taxinomitis/blob/9c1fbc7ff5cd6e723456d679908e161f0c5d992e/public/languages/ro.json#L1685

is displayed in the block like

dalelane commented 3 years ago

@oana-sipos FYI - this is live now. Thanks again!

oana-sipos commented 3 years ago

Thanks for the explanations, @dalelane, now it makes sense. Coming back with a new set of changes.