IBM / taxinomitis

Source code for Machine Learning for Kids site
https://machinelearningforkids.co.uk
Apache License 2.0
138 stars 133 forks source link

Fix for Dockerfile smell DL3015 #474

Closed grosa1 closed 1 year ago

grosa1 commented 1 year ago

Hi! The Dockerfile placed at "mlforkids-numbers/Dockerfile" contains the best practice violation DL3015 detected by the hadolint tool.

The smell DL3015 occurs when the apt tool is used to install packages without the "--no-install-recommends" flag. This flag is recommended to be used to avoid installing additional packages not explicitly requested. In this pull request, we propose a fix for that smell generated by our fixing tool. We have verified that the patch is correct before opening the pull request. To fix this smell, specifically, the "--no-install-recommends" flag is added to the apt-get install command.

This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.

Thanks in advance