IBM / taxinomitis

Source code for Machine Learning for Kids site
https://machinelearningforkids.co.uk
Apache License 2.0
144 stars 137 forks source link

[Request] Image Upload via File Picker #482

Closed FunkMonkey closed 7 months ago

FunkMonkey commented 1 year ago

It would be nice if additionally to Image URLs, Webcam and Drawings, images could also be uploaded via a file picker! Especially on mobile devices, the adding of images via URLs is quite cumbersome and an alternative would be appreciated. Given that webcam and drawings already send images to the server, I assume there wouldn't be much development work...

Thanks!

dalelane commented 1 year ago

Sorry - this was an intentional decision. Essentially, storing image files is super expensive. I don't want to encourage it.

Yes, making users store an image somewhere else and then give me a short string URL to store is absolutely a bit of a hassle for them. But it's orders of magnitude cheaper from my running costs perspective.

You're right to point out that I've made an exception for drawings and webcam... and that was a difficult decision to make. Ultimately I'm taking the storage costs hit to enable projects that otherwise couldn't be done. But storing other images is harder to justify in that way.

FunkMonkey commented 1 year ago

Hi @dalelane,

Thank you for your quick reply! I totally understand this, especially when you are the one(s) paying the bills!

What about handling this via a server option? This way admins of self-hosted ML4Kids instances could decide this for themselves? In my scenario, I would just host my own instance via Docker on our own servers. As we only use ML4Kids irregularly, it wouldn't be much storage and I would probably delete the volumes once in a while anyway...

dalelane commented 1 year ago

Yeah - that's perfectly reasonable. To be honest, I'm naturally less motivated to work on features that I'm not going to use myself, so while I don't object to it, I should be clear that it's unlikely this would make it to the top of my todo list any time soon.

dalelane commented 7 months ago

I've added this now for local projects where I don't need to worry about the storage implications

https://github.com/IBM/taxinomitis/commit/8511b295f1c6f87f23287f74663ede4628131277