Open necccc opened 3 years ago
In 0.5.2 we should report missing parameters in taskSpec tasks
Example:
- name: inline-task params: - name: pipeline-debug value: $(params.pipeline-debug) workspaces: - name: secrets workspace: artifacts taskSpec: workspaces: - name: secrets mountPath: /secrets params: - name: pipeline-debug stepTemplate: env: - name: PIPELINE_RUN_ID valueFrom: fieldRef: fieldPath: metadata.annotations['devops.cloud.ibm.com/tekton-pipeline'] steps: - name: setup image: node:alpine script: | #!/bin/bash set -e -o pipefail if [ $PIPELINE_DEBUG == 1 ]; then pwd env trap env EXIT set -x fi export TOKEN=$(cat "/secrets/$(params.token)")
The line export TOKEN=$(cat "/secrets/$(params.token)") use a parameter token which was not added nor provided for the task, the linter is missing this.
export TOKEN=$(cat "/secrets/$(params.token)")
token
Hi - yes it's a good idea; at present there's only 1 rule that checks inside the body of the scripts.
To any contributors out there.. please have a go! thanks
In 0.5.2 we should report missing parameters in taskSpec tasks
Example:
The line
export TOKEN=$(cat "/secrets/$(params.token)")
use a parametertoken
which was not added nor provided for the task, the linter is missing this.