Closed CarlosGomes98 closed 2 days ago
@CarlosGomes98 @romeokienzler General comment. I reviewed the new way to define factories and registries. I believe it simplifies the entire process and introduces clarification for some parts (specially for the registries). Even though it creates some conflicts for two open PRs, I believe it's easier to solve these conflicts when these modifications are already in the main branch. Especially considering that the pretraining and mmseg PRs are not so urgent.
@CarlosGomes98 @romeokienzler General comment. I reviewed the new way to define factories and registries. I believe it simplifies the entire process and introduces clarification for some parts (specially for the registries). Even though it creates some conflicts for two open PRs, I believe it's easier to solve these conflicts when these modifications are already in the main branch. Especially considering that the pretraining and mmseg PRs are not so urgent.
Thanks for the work reviewing this! I know it was a lot :)
This pr addresses #135
It does quite a few things:
As future steps after this is merged, a lot of existing factories can either be removed / deprecated (as with PrithviModelFactory) or simplified greatly.
This PR does not break PrithviModelFactory, but modifies it to use the EncoderDecoderFactory. It is marked as deprecated and should be removed in the future. But for now this should not break any back compatibility.