search

IBM / transition-amr-parser

SoTA Abstract Meaning Representation (AMR) parsing with word-node alignments in Pytorch. Includes checkpoints and other tools such as statistical significance Smatch.
Apache License 2.0
237 stars 45 forks source link

j>i? #51

Closed Zoher15 closed 1 year ago

Zoher15 commented 1 year ago

https://github.com/IBM/transition-amr-parser/blob/849b1ee69370240c423cb987a02103693c951027/scripts/mbse.py#L300

Hello,

I was wondering why this above line is different from line 284? Isn't this doing redundant calculations? Or am I understanding something wrong?

Best, Zoher

ramon-astudillo commented 1 year ago

Yes, but that operation has no cost so it's irrelevant.