Fix error message in mounter_utils (per Dana review UB-1230) and fix fake file

IBM / ubiquity

Ubiquity

Apache License 2.0

90 stars 26 forks source link

Fix error message in mounter_utils (per Dana review UB-1230) and fix fake file #214

Closed shay-berman closed 6 years ago

shay-berman commented 6 years ago

@danare found a wrong text in error message in #212. The error DirPathAlreadyMountedToWrongDevice message was included the variable type. For example : "devices=[]string{"/dev/mapper/mpathv", "/dev/mapper/mpathv2"}". So this PR fixs the text so it will be "devices=[/dev/mapper/mpathv /dev/mapper/mpathv2]"

In addition, I saw that I didn't align the a fake file with renamed interface isDirAMountPoint. So used this PR to fix that as well, so the UT should pass OK now.

This change is

coveralls commented 6 years ago

Coverage decreased (-0.07%) to 53.75% when pulling d931ba3119147b7806aa9440c1a8d58b948ae251 on fix/UB_1230_prevent_doublemounting_fix_error into 1eecd5f25441f76659af26cab9cdefd3f09a4129 on dev.

olgashtivelman commented 6 years ago

Review status: 0 of 2 files reviewed at latest revision, all discussions resolved, some commit checks failed.

Comments from Reviewable