search

IBM / ubiquity

Ubiquity
Apache License 2.0
90 stars 26 forks source link

Fix/ub 1325 adda action name to the logs #219

Closed olgashtivelman closed 6 years ago

olgashtivelman commented 6 years ago

this PR will add an action name to each log line. (for example all oprerations that are part of Delete will have the request-action name in the log. like : fd5dd389-7acb-11e8-88cd-54ee75515403-Delete

This change is Reviewable

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.08%) to 51.398% when pulling 602ff4ee1229c80ad7bc077813aa74ab437d822d on fix/UB-1325_adda_action_name_to_the_logs into 250d07176fd4ac7b76f35d0240fe059e894f6bf8 on dev.

shay-berman commented 6 years ago

Review status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @olgashtivelman and @shay-berman)

utils/logs/go_logging_logger.go, line 86 at r3 (raw file):


  if l.params.ShowGoid{
      return fmt.Sprintf("%s:%d-%s", new_context.Id, go_id, new_context.ActionName)

whats happen if action name not given in the context?
I think we should succeed to work but without show the action name.

Comments from Reviewable