search

IBM / ubiquity

Ubiquity
Apache License 2.0
90 stars 26 forks source link

Fix/ub 1675 support fc and iscsi #267

Closed olgashtivelman closed 5 years ago

olgashtivelman commented 6 years ago

in this PR the idea is to allow the user to use ISCSI + FC on the same kubernetes cluster. before this PR the user had to define a config parameter : skipRescanIscsI to define if they want to use ISCSI or not in ubiquity. this PR reomves this config and works under the assumption that if a user defined and installed iscsiadm on the node then this node should be connected to the storage system with ISCSI. also the existance of the iscsiadm command or a login to the storage will not fail the rescan and the mount\umount process!

Note: This PR also related to https://github.com/IBM/ubiquity-k8s/pull/254

This change is Reviewable

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.04%) to 58.296% when pulling 08f2b984ba46f4e845720ebb19bc6d34d59a8634 on fix/UB-1675_support_fc_and_iscsi into 593eab53c734ef364a7f8871651d1ab3ce5f0188 on dev.