search

IBM / ubiquity

Ubiquity
Apache License 2.0
90 stars 26 forks source link

Fix/ub-1722 soft link issue on uncleared node #274

Closed olgashtivelman closed 5 years ago

olgashtivelman commented 5 years ago

in this PR the issue that is solved is the following: as part of the mount there is a check made to see if there are any solf links pointing to the desired mount point ( to /ubiquity/WWN) -this is needed in order to not allow 2 pods to be attached to the same PVC. an issue may accur when one of those soft links is not actually active (for example of a pod moving to another node in the cluster and back to the original one due to shutdowns) - this is what this PR solves. beside checking if any soft links exists - a check is made to see if the mount point is mounted. if it is then this is a valid solf link and the current mount should fail. otherwise the current mount can continue un-interrupted.

This change is Reviewable

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.04%) to 58.774% when pulling 3bb8f053e03ee78acab907e8320d3e003ef740f3 on fix/UB-1722_soft_link_issue_on_uncleared_node into f37a22295ddae4d31e70209177df993e9d81fc5a on dev.