IBM / ubiquity

Ubiquity
Apache License 2.0
90 stars 26 forks source link

UB-1977 exclude the warning messages in multipath output #303

Closed 27149chen closed 5 years ago

27149chen commented 5 years ago

The multipath output might print some warning messages if some devices are faulty, it has impact on the function isDeviceFaulty. I have no time to improve this fucntion, I will exclude these messages in 2.1 release.

Here is an example output:

Apr 04 16:13:40 | sde: couldn't get target port group
Apr 04 16:13:40 | sdd: couldn't get target port group
mpathj (3600507680c8701159800000000001af4) dm-17 IBM     ,2145            
size=1.0G features='1 queue_if_no_path' hwhandler='0' wp=rw
|-+- policy='service-time 0' prio=0 status=active
| `- 39:0:0:1 sde 8:64 failed faulty running
`-+- policy='service-time 0' prio=0 status=enabled
  `- 40:0:0:1 sdd 8:48 failed faulty running
mpathi (3600507680c8701159800000000001af3) dm-14 IBM     ,2145            
size=20G features='1 queue_if_no_path' hwhandler='0' wp=rw
|-+- policy='service-time 0' prio=50 status=active
| `- 40:0:0:0 sdb 8:16 active ready running
`-+- policy='service-time 0' prio=10 status=enabled
  `- 39:0:0:0 sdc 8:32 active ready running

This change is Reviewable

coveralls commented 5 years ago

Coverage Status

Coverage increased (+0.2%) to 59.359% when pulling 527910e1b470d420cb9ccd696ff5de3628ab0440 on feature/UB-1977_warning_messages_in_multipath_output into 3f22f0ef8a4ebccdfacf732d32c087986c51e2a6 on dev.

shay-berman commented 5 years ago

+1